Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): replaces deprecated linter package #127

Merged
merged 1 commit into from
Feb 3, 2022
Merged

chore(eslint): replaces deprecated linter package #127

merged 1 commit into from
Feb 3, 2022

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Feb 3, 2022

Related Ticket(s)

#109

Description

Replace eslint dependencies with latest. Based on changes made in carbon-design-system/carbon-for-ibm-dotcom-web-components-template#91.

Changelog

Changed

  • replace eslint-loader with eslint-webpack-plugin
  • replace babel-eslint parser with @babel/eslint-parser

@kennylam kennylam requested a review from a team as a code owner February 3, 2022 16:55
@kennylam kennylam requested a review from emyarod February 3, 2022 16:55
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created:
https://ibmdotcom-web-components-html-test.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/127/index.html

Built with commit: 98f80d3c566fc4c1a4b44f704c4fa0c39407d436

emyarod
emyarod approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Feb 3, 2022
Closed
@kodiakhq kodiakhq bot merged commit 98b4f94 into carbon-design-system:main Feb 3, 2022
@kennylam kennylam deleted the chore/upgrade-babel-webpack-eslint-loader branch February 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @emyarod